Skip to content

feat (audience match types): Update audience evaluator and project config for new audience match types #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2018
Merged

feat (audience match types): Update audience evaluator and project config for new audience match types #145

merged 2 commits into from
Dec 21, 2018

Conversation

@oakbani
Copy link
Contributor

@oakbani oakbani commented Dec 19, 2018

Summary

This updates project config and the audience evaluator to finish the implementation of typed audience evaluation:

  • In validator:isUserInExperiment, allow evaluation to continue when no user attributes are passed (previously we were immediately returning false when no attributes were passed)
  • Updated project_config to update audienceIdMap with typedAudiences
  • Added unit tests checking that all top-level methods that accept user attributes can bucket users into experiments or rollouts that use typed audiences.

Test Plan

  • New & existing unit tests
  • Ran compatibility suite tests for typed audiences

@oakbani
Copy link
Contributor Author

oakbani commented Dec 19, 2018

The project config decodes whole datafile in a way that converts json objects to associative arrays in PHP. This creates a difference in the way we handle normal audience conditions and typedAudience conditions as in other SDKs. The leaf condition inside typedAudiences auto convert into an associative array. Hence, I have changed the normal audience conditions decoding to sync it with typedAudience. And modified conditionTree/CustomAttr evaluators a bit to handle leaf nodes as arrays instead of objects.

aliabbasrizvi
aliabbasrizvi approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to understand why stringified number as a key is returning false for doesArrayContainOnlyStringKeys

@aliabbasrizvi aliabbasrizvi merged commit d617d18 into oakbani/audience-match-condition-evaluator-2 Dec 21, 2018
aliabbasrizvi added a commit that referenced this pull request Dec 21, 2018
@aliabbasrizvi
Revert "feat (audience match types): Update audience evaluator and pr…
2e27873 
…oject config for new audience match types (#145)"

This reverts commit d617d18.
@aliabbasrizvi aliabbasrizvi mentioned this pull request Dec 21, 2018
Closed
oakbani added a commit that referenced this pull request Dec 24, 2018
@oakbani
feat(audience match types): Update condition evaluator for new audien…
b9b3ba4 
…ce match types (#143)

* feat(audience match types): Update condition evaluator for new audience match types

* feat (audience match types): Update audience evaluator and project config for new audience match types (#145)
@oakbani oakbani mentioned this pull request Dec 24, 2018
Merged
@oakbani oakbani deleted the oakbani/audience-match-project-config-2 branch December 31, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

@nchilada nchilada Awaiting requested review from nchilada

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oakbani @aliabbasrizvi